search

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.26k stars 1.54k forks source link

Cocoa Beans don't call BlockGrowEvent #4533

Closed ColinHDev closed 2 years ago

ColinHDev commented 2 years ago

Issue description

As cocoa beans are plants, they should call the BlockGrowEvent when they grow.

Proof

https://github.com/pmmp/PocketMine-MP/blob/master/src/block/CocoaBlock.php#L97-#L99 https://github.com/pmmp/PocketMine-MP/blob/master/src/block/CocoaBlock.php#L120-#L122

OS and versions

Plugins

dktapps commented 2 years ago

API change request template would have suited better.

ColinHDev commented 2 years ago

oops, I was unsure which I should choose

dktapps commented 2 years ago

This seems like an easy PR if anyone wants to try it.

ColinHDev commented 2 years ago

Can do, just didn't had time yesterday

ColinHDev commented 2 years ago

Resolved by https://github.com/pmmp/PocketMine-MP/pull/4536