search

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.25k stars 1.53k forks source link

/particle itembreak crashes the server if item ID is too big #4655

Closed dktapps closed 1 month ago

dktapps commented 2 years ago

Link to crashdump: https://crash.pmmp.io/view/5626306

Additional comments

dktapps commented 2 years ago

A good question to ask would be why this is still using plain item IDs instead of something like StringToItemParser ...

dktapps commented 1 month ago

This was fixed by https://github.com/pmmp/PocketMine-MP/commit/2a24982bc4e5b4fbe3c85a4a44c67427ada4ec2c