Effect problem - Githubissues

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.26k stars 1.54k forks source link

Effect problem #4730

Closed achedon12 closed 2 years ago

achedon12 commented 2 years ago

Issue description

Expected result: What were you expecting to happen? Normally, there should be a gain in speed effect
Actual result: What actually happened? It gives the effect for 1s instead of 20. It works for different effects but not for all, the duration makes the effect buggy (ex: speed, resistance)

Steps to reproduce the issue

give a speed effect in new instance with a duration (it doesn't matter which one) and an amplification

OS and versions

PocketMine-MP:
PHP:
Using JIT: yes/no (delete as appropriate)
Server OS:
Game version: Android/iOS/Win10/Xbox/PS4/Switch (delete as appropriate)

Plugins

If you remove all plugins, does the issue still occur? Yes
If the issue is not reproducible without plugins:
- Have you asked for help on our forums before creating an issue? Yes
- Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section $player->getEffects()->add(new EffectInstance(VanillaEffects::SPEED(), 2147483647/2, 2, true));

Crashdump, backtrace or other files

dktapps commented 2 years ago

EffectInstance takes a duration argument in ticks.

achedon12 commented 2 years ago

It still doesn't solve the problem. Try the code, and you'll see that it won't work

dktapps commented 2 years ago

I did try it. It works fine.