Brewing stand has wrong collide box? Block has more type of boxes?

NTT1906 commented 2 years ago

Issue description

Expected result: Arrow/projectile got stuck at the select/pick-up boxes.
Actual result: It goes through the select/pick-up boxes but stops at collision boxes.

In vanilla

Steps to reproduce the issue

Try throwing a trident or shooting an arrow, any projectile to brewing stand.
Try again in vanilla

OS and versions

PocketMine-MP: build from the current stable branch. After BrewingStand: fixed collision box
PHP: 8.0
Server OS: Window
Game version: Win10 (1.18.2, 1.17.2 dev version, 1.16.30 dev version)

Plugins

None

Crashdump, backtrace, or other files

N/A

Disparity between bedrock and PMMP:

In bedrock vanilla, there are multi-type of boxes included:

Outline boxes: (Red /orange): unknown, maybe item collection? Both block, entity, and even player have these boxes.
Structure Bounding boxes (Green): mob spawning at a specific place
Entity's bounding boxes (Blue): this is for contact with the block collision box, entity's hitbox?
Block's collision boxes (Blue): this was made for dealing with contact collision, making block solid, entities cannot go through this.
Select/pick-up boxes/ hitbox? (Black / Dark grey?): to interact with the block: destroy, get,...
Second collision boxes (Yellow?): this behaves in a strange way, it seems like this is for projectile collision... (Arrow got stuck when arrow both collide with this and pick-up boxes) The arrow should fall down but it doesn't in vanilla Also, the overdraw line didn't render so those boxes showed up isn't really the real size of the box

In PMMP, there are only collisions boxes and bounding right ~~?

inxomnyaa commented 2 years ago

https://github.com/pmmp/PocketMine-MP/commit/6679c53e56f4d23a96e41998d9e8dcacc1300cfa

NTT1906 commented 2 years ago

6679c53

this is about it :l

dktapps commented 2 years ago

Actually it's correct for Bedrock. Java is not a suitable test bed for these things.

NTT1906 commented 2 years ago

Actually it's correct for Bedrock. Java is not a suitable test bed for these things.

umm, you could try it in vanilla ^-^

NTT1906 commented 2 years ago

in vanilla, arrow will collide like this.

dktapps commented 2 years ago

I did. That's not what I saw.

NTT1906 commented 2 years ago

I did. That's not what I saw.

wdym, i'm confused

dktapps commented 2 years ago

The current behaviour matches Java, which, IMO, makes a lot more sense and looks less stupid.

NTT1906 commented 2 years ago

The current behaviour matches Java, which, IMO, makes a lot more sense and looks less stupid.

this is true but what i'm about to say is Minecraft Bedrock has two type of collision boxes, one for normal entity included players and one for projectile. At least, it's a thing in bugrock :p

dktapps commented 2 years ago

That's a thing in JE too, so that arrows don't get stuck in the air above fences. That's not implemented yet.

pmmp / PocketMine-MP