Incorrect bounding box for Nether Brick Fence and other adjacent fences - Githubissues

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.28k stars 1.56k forks source link

Incorrect bounding box for Nether Brick Fence and other adjacent fences #5603

Open DaisukeDaisuke opened 1 year ago

DaisukeDaisuke commented 1 year ago

Issue description

Expected result: Nether Brick Fence's boundingBox does not connect with other fences.
Actual result: A Nether Brick Fence behaves as if it were connected to another fence.

Steps to reproduce the issue

Place another fence next to the Nether Brick Fence.
Check the boundingbox by summoning zombies, giving them knockbacks, etc.

OS and versions

PocketMine-MP: 4.15.2 and 5.0.0-ALPHA9
PHP: 8.0.28
Using JIT: no
Server OS: Win10
Game version: Win10

Plugins

none

Crashdump, backtrace or other files

java 1.19.3

Minecraft Screenshot 2023 03 04 - 20 49 08 86

pmmp

Minecraft Screenshot 2023 03 04 - 19 44 03 81

pm4

https://github.com/pmmp/PocketMine-MP/blob/0edc5f81138afec6099b48e81104b7a84f6f6d46/src/block/Fence.php#L40-L52 https://github.com/pmmp/PocketMine-MP/blob/stable/src/block/Fence.php#L40

pm5

probably the same https://github.com/pmmp/PocketMine-MP/blob/major-next/src/block/Fence.php#L40

dktapps commented 1 year ago

This probably broke whenever the NetherBrickFence class was removed. instanceof static is evil...