Closed dktapps closed 1 year ago
It appears that writing in a book generates a transaction, even though the change is already handled by BookEditPacket.
Since 4.18 expects that regular transactions will only be used for dropping items, this causes InGamePacketHandler to freak out and kick the player.
Sample packet trace:
[07:37:37.565] [Server thread/DEBUG]: [NetworkSession: mctestDylan] InventoryTransactionPacket: HgAAAwAAAIgIAQAAAABM//8BCgAACQUAcGFnZXMKAgAAAAgJAHBob3RvbmFtZQAACAQAdGV4dAAAAAgJAHBob3RvbmFtZQAACAQAdGV4dAAAAAAAAAAAAAAAAIgIAQAAAABR//8BCgAACQUAcGFnZXMKAgAAAAgJAHBob3RvbmFtZQAACAQAdGV4dAUAaGVsbG8ACAkAcGhvdG9uYW1lAAAIBAB0ZXh0AAAAAAAAAAAAAAAAAwAAiAgBAAAAAEz//wEKAAAJBQBwYWdlcwoCAAAACAkAcGhvdG9uYW1lAAAIBAB0ZXh0AAAACAkAcGhvdG9uYW1lAAAIBAB0ZXh0AAAAAAAAAAAAAAAAAwGICAEAAAAAUf//AQoAAAkFAHBhZ2VzCgIAAAAICQBwaG90b25hbWUAAAgEAHRleHQFAGhlbGxv AAgJAHBob3RvbmFtZQAACAQAdGV4dAAAAAAAAAAAAAAAAAA= [07:37:37.565] [Server thread/ERROR]: [NetworkSession: mctestDylan] Bad packet: Error processing InventoryTransactionPacket: Expected exactly 2 actions for dropping an item
Fixed by 811639f2cdfead34cc0412f9fc76584661226ebf.
Issue description
It appears that writing in a book generates a transaction, even though the change is already handled by BookEditPacket.
Since 4.18 expects that regular transactions will only be used for dropping items, this causes InGamePacketHandler to freak out and kick the player.
Sample packet trace:
Steps to reproduce the issue
OS and versions