Offhand inventory doesn't work

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.25k stars 1.53k forks source link

Offhand inventory doesn't work #5667

Closed Aduqate closed 1 year ago

Aduqate commented 1 year ago

Issue description

Placing any item in the offhand slot will simply prevent it from being placed there.

Expected result: The Item should be placed in the offhand slot
Actual result: Item doesn't go in the offhand slot

Steps to reproduce the issue

Place an item in the offhand slot

OS and versions

PocketMine-MP: 4.18.2
PHP: 8.0.28
Using JIT: no
Server OS: linux
Game version: Win10

Plugins

If you remove all plugins, does the issue still occur? Yes

Crashdump, backtrace or other files

dktapps commented 1 year ago

Can you try to reproduce this with debug.level set to 2 in pocketmine.yml and paste the output?

dktapps commented 1 year ago

[22:59:32.269] [DEBUG] [NetworkSession: mctestDylan] ItemStackRequest #-3 failed: Error processing action 0 (PlaceStackRequestAction): No such inventory slot :PlayerOffHandInventory#26773, slot: 1 [22:59:32.269] [DEBUG] [NetworkSession: mctestDylan] pocketmine\network\mcpe\handler\ItemStackRequestProcessException: "Error processing action 0 (PlaceStackRequestAction): No such inventory slot :PlayerOffHandInventory#26773, slot: 1" (EXCEPTION) in "pmsrc/src/network/mcpe/handler/ItemStackRequestExecutor" at line 363

This looks like some kind of weird bug in the client.

dktapps commented 1 year ago

Dragonfly has worked around the issue here: https://github.com/df-mc/dragonfly/blame/365f21525f4598e139fb59811486e4ba6630453e/server/session/handler_item_stack_request.go#L408