pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.27k stars 1.55k forks source link

setBaseDamage is bugged/misleading #5782

Closed MINTEDCLICKS closed 1 year ago

MINTEDCLICKS commented 1 year ago

setBaseDamage also modifies the hit cooldown. this shouldnt be the case. it should only apply to the base damage as the name indicates

one may just use setAttackCooldown for setting the attack cooldown, setBaseDamage should be solely for the damage.

dktapps commented 1 year ago

⚠️ This issue ticket doesn't have all the required information ⚠️ To make it as quick and easy as possible for maintainers to fix your problem, an issue template is provided which lists certain required information. This includes (but is not limited to):

Without this information, your problem cannot begin to be investigated, so the issue will be closed. You may amend this one, or create a new one, providing all the required information using one of the provided issue templates.

Help us to help you by providing the information we ask for.