Storing local variables when Item::onAttackEntity is called

[Aboshxm2]

Issue description

When overriding onAttackEntity for custom items, it is not possible to store variables when the method is called.

• Expected result: What were you expecting to happen? I expect to be able to store variables when overriding the onAttackEntity method for custom items.
• Actual result: What actually happened? It returns to its initial values.

OS and versions

• PocketMine-MP: 5.8.2
• PHP: 8.1.26
• Using JIT: no (delete as appropriate)
• Server OS: linux
• Game version: Win10 (delete as appropriate)

Plugins

• If you remove all plugins, does the issue still occur?
• If the issue is not reproducible without plugins:
  • Have you asked for help on our forums before creating an issue?
  • Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section

Crashdump, backtrace or other files

$id = ItemTypeIds::newId();
        $item = (new class(new ItemIdentifier($id)) extends Item {
            public int $myVariable = 0;

            public function onAttackEntity(Entity $victim, array &$returnedItems): bool
            {
                $this->myVariable = 1;
                return false;
            }
        });

        $this->getServer()->getPluginManager()->registerEvent(EntityDamageByEntityEvent::class, function (EntityDamageByEntityEvent $event) use ($id): void {
            $attacker = $event->getDamager();
            if(!$attacker instanceof Player) return;

            $item = $attacker->getInventory()->getItemInHand();
            if($item->getTypeId() === $id) {
                $attacker->sendMessage((string)$item->myVariable);
            }
        }, EventPriority::MONITOR, $this);

[Aboshxm2]

It seems that because the item is equal to the old item (it's actually not), the item won't be replaced in the inventory.

So, I don't know, the Item::equalsExact should be overridable

[github-actions[bot]]

Hi, we only accept bug reports on this issue tracker, but this issue looks like a support request.

Instead of creating an issue, try the following:

• Check our Documentation to see if you can find answers there
• Ask the community on our Discord server or our Forums

Docs | Discord | Forums