pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.28k stars 1.55k forks source link

Unexpected trailing data after 3D biomes data #6290

Open TheLemzz opened 7 months ago

TheLemzz commented 7 months ago

Steps to reproduce the issue

  1. Create a world on Minecraft: Java Edition(1.20.4) and convert it to Minecraft: Bedrock Edition(1.20.60) format.
  2. Start the server and load some chunks.

Result: the world is working and loading correctly, no "broken" blocks were found, but the entire console was spammed with the following message: [World Provider: world] [Loading chunk x=SOMETHING z=SOMETHING v40] Unexpected trailing data after 3D biomes data

used plugins: DummyItemsBlocks (from poggit)

PM 5.12.1

pandaaaBE commented 7 months ago

"it will fill the biomes with a default which might cause unexpected behaviour"

"e.g. weather might behave strangely"

"or grass & leaves might be the wrong colour"

"but otherwise the world should work normally"

~dylan

Just ignore the errors or convert it with Chunker

TheLemzz commented 7 months ago

The fact of spam in the console and the complete inability to read it normally annoys me. Dozens of players will load chunks every second. In addition, this error appears even after loading already loaded chunks in the past(you logged in, uploaded chunks, got an error - re-logged in and got an error again). Chunker has a limit on the size of the convertible world, and as the owner of a 7.000x7.000 world it is impossible for me to use Chunker.

pandaaaBE commented 7 months ago

The fact of spam in the console and the complete inability to read it normally annoys me. Dozens of players will load chunks every second. In addition, this error appears even after loading already loaded chunks in the past(you logged in, uploaded chunks, got an error - re-logged in and got an error again). Chunker has a limit on the size of the convertible world, and as the owner of a 7.000x7.000 world it is impossible for me to use Chunker.

The upload limit is 1GB you could split the region directoy and convert it..

or maybe je2be supports 3d biomes

TheLemzz commented 7 months ago

For some reason, worlds converted via je2be do not work on PM =( I`m not sure that splitting the world directory and merging it won't cause problems\bugs\errors

pandaaaBE commented 7 months ago

For some reason, worlds converted via je2be do not work on PM =( I`m not sure that splitting the world directory and merging it won't cause problems\bugs\errors

If you do it right there should be no problems, one chunk is one file..

someone on the discord said that je2be fixes the 3d biome error, maybe try the app version of je2be?

TheLemzz commented 7 months ago

I used latest version of je2be and when I converted the world, PocketMine was crashed due to an unknown ID "randomSeed" in the world

pandaaaBE commented 7 months ago

I used latest version of je2be and when I converted the world, PocketMine was crashed due to an unknown ID "randomSeed" in the world

you have to start the world normally with minecraft first after the conversion, I think so

TheLemzz commented 7 months ago

k, I start the world(converted by je2be) before installing it on PocketMine and it worked, but it didn't solve the "Unexpected trailing" problem

pandaaaBE commented 7 months ago

k, I start the world(converted by je2be) before installing it on PocketMine and it worked, but it didn't solve the "Unexpected trailing" problem

okay sorry then chunker is the only option to fix this..

there is a paid converter but I can not recommend it

TheLemzz commented 7 months ago

regarding the proposal to split the directory of the world and convert it in parts. As a result, this does not work, because the convertible parts of the world overwrite each other's chunks, because they have the same name. in addition, the LOG file is different in some parts of the world (however, I don't think this is critical).

dadodasyra commented 7 months ago

You can use the pocketmine converter from the converted map to a new one. Or basically you can load every chunk one time with a plugin so it disappears.

Here's a gist of the code to remove those errors. https://gist.github.com/dadodasyra/1e031289fa50ba6c057022641bf5abd1 To an easy usage you should run it through a pmmp plugin, be aware that it freezes the server until the end and dependently of the size of the world and hardware it can take a significantly amount of time (up to 10 hours).

TheLemzz commented 7 months ago

You can use the pocketmine converter from the converted map to a new one. Or basically you can load every chunk one time with a plugin so it disappears.

Your code doesn't work(server crash without crashdump)

dadodasyra commented 7 months ago

You can use the pocketmine converter from the converted map to a new one. Or basically you can load every chunk one time with a plugin so it disappears.

Your code doesn't work(server crash without crashdump)

I used it on PM5 and it was working like a charm. Can you give more detail, did you changed what you should change ? How are you implementing it

TheLemzz commented 7 months ago

did you changed what you should change ? How are you implementing it

Like a plugin that onCommand converts the world along the directory. Yes, a changed directory