Make access modifier consistent with parent abstract class - Githubissues

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.23k stars 1.51k forks source link

Make access modifier consistent with parent abstract class #6341

Closed ItsMax123 closed 1 month ago

ItsMax123 commented 2 months ago

Introduction

SpawnEgg's abstract createEntity function is protected and these should be as well.

Relevant issues

This is just for consistency's sake and does not fix any known bugs.

Changes

API changes

None

Behavioural changes

None

Backwards compatibility

None

Follow-up

None

Tests

I tested this PR by doing the following (tick all that apply):

[ ] Writing PHPUnit tests (commit these in the tests/phpunit folder)
[ ] Playtesting using a Minecraft client (provide screenshots or a video)
[ ] Writing a test plugin (provide the code and sample output)
[ ] Other (provide details)