pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP
https://pmmp.io
GNU Lesser General Public License v3.0
3.23k stars 1.51k forks source link

Adjust pretty name of closures on PHP 8.4 #6351

Open staabm opened 1 month ago

staabm commented 1 month ago

Introduction

related to https://github.com/php/php-src/pull/13550

see analog symfony change: https://github.com/symfony/symfony/pull/54614

Relevant issues

Changes

API changes

Behavioural changes

Backwards compatibility

Follow-up

Tests

I tested this PR by doing the following (tick all that apply):

ShockedPlot7560 commented 1 month ago

PHP 8.4 is not officially supported

staabm commented 1 month ago

I was just crawling thru github for this particular php compat problem.

Its not important for me to make this repo PHP 8.4 compatible

dktapps commented 1 month ago

I think this would be better filled by using ReflectionFunction::isAnonymous in 8.2 and up

staabm commented 1 month ago

I think this would be better filled by using ReflectionFunction::isAnonymous in 8.2 and up

thats right, but it would require raising the min-php version requirement