fix: version command issues - Githubissues

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.23k stars 1.51k forks source link

fix: version command issues #6357

Open nicholass003 opened 4 weeks ago

nicholass003 commented 4 weeks ago

Introduction

This pull request is to handle users using the version command for detailed things, such as checking plugin information.

Relevant issues

Fixes https://github.com/pmmp/PocketMine-MP/issues/6322

Changes

API changes

Added DefaultPermissionNames::COMMAND_VERSION_DETAIL -> Allows the user to view the detailed version of the server.

Behavioural changes

Backwards compatibility

Follow-up

Tests

I tested this PR by doing the following (tick all that apply):

[ ] Writing PHPUnit tests (commit these in the tests/phpunit folder)
[ ] Playtesting using a Minecraft client (provide screenshots or a video)
[ ] Writing a test plugin (provide the code and sample output)
[ ] Other (provide details)

nicholass003 commented 19 hours ago

Need translation follow up

just added english for now, https://github.com/pmmp/Language/pull/182