Always hide username not working in certains conditions - Githubissues

pmmp / PocketMine-MP

A server software for Minecraft: Bedrock Edition in PHP

https://pmmp.io

GNU Lesser General Public License v3.0

3.28k stars 1.56k forks source link

Always hide username not working in certains conditions #6537

Open dadodasyra opened 2 days ago

dadodasyra commented 2 days ago

Issue description

Expected result: The player username should be hidden
Actual result: When some conditions are met the username is visible through blocks

Steps to reproduce the issue

Two players connects

One player (player A) triggers something which will calls this on himself

$sender->setNameTagAlwaysVisible(false);
$sender->setNameTagVisible(false);

The other player (player B) will still be able to see its username.

It does work if the player B disconnects and reconnects (the player needs to login after the hidden username one).

OS and versions

PocketMine-MP: 5.21.1
PHP: 8.2.17
Using JIT: no
Server OS: Debian 11 (or 12 dk)
Game version: All (tested on android + windows in both ways)

Plugins

If you remove all plugins, does the issue still occur? Tried with just the example plugin + devtools and yes.
If the issue is not reproducible without plugins:
- Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section Here's the "full" example plugin used (just added the previous sent code) Exampleplugin.zip

Crashdump, backtrace or other files

Here's two recording of me reproducing the bug. The Windows one is the player A and the android one is player B, both videos are almost in sync.

Windows: https://github.com/user-attachments/assets/fe7fb658-93cb-44e9-8b4e-af826c1d5a2a

Android: https://github.com/user-attachments/assets/c63b6106-15d6-45f2-a5b3-1e550729f0ce

dadodasyra commented 2 days ago

The more I think about it the more I'm asking myself if it's not a client side bug ? It definitely needs some investigation