pmndrs / detect-gpu

Classifies GPUs based on their 3D rendering benchmark score allowing the developer to provide sensible default settings for graphically intensive applications.
MIT License
1.04k stars 57 forks source link

Wrong "device" name #101

Open emirefek opened 2 years ago

emirefek commented 2 years ago

Hello, thanks for this awesome tool for three.js but I found a little bug in my mobile phone. I'm using "Samsung Galaxy S21 Ultra" but the live demo page in the README.md says the device it is "huawei mate 40 pro 5g". It's really wrong but probably it's guessed it from the GPU model because both that Huawei's SoC and S21U's SoC has same "ARM Mali-G78" gpu. I think rather then guessing the phone it'll be more accurate to just leave the GPU model with device specific display info. Or this guessing algorithm needed to change with better one with some values to stand on more then just GPU model and display info. Because nearly all SoC other then Qualcomm ones uses Mali GPUs in Android devices and this can cause really trouble to developers who didn't get this bug while developing.