pmndrs / drei-vanilla

🍦 drei-inspired helpers for threejs
https://pmndrs.github.io/drei-vanilla/
MIT License
448 stars 17 forks source link

sb7 #20

Closed vis-prime closed 1 year ago

vis-prime commented 1 year ago

Why

Story book has a pop up to update itself

What

following the updates in drei, trying to make them work here

Checklist

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c88336cafc78e1e5b9aa55403cf973a3fa31e4c1:

Sandbox Source
optimistic-smoke-zpgr2n Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration
vis-prime commented 1 year ago

@abernier

i had to install cross-env and the stotybook command was changed to

"storybook": "cross-env NODE_OPTIONS=\"--openssl-legacy-provider\" storybook dev -p 6006", (also switched from npm to yarn for package managing)

it's working now but

in setup.ts the root variable is blank root

abernier commented 1 year ago

i had to install cross-env and the stotybook command was changed to

are you on a "windows" environment? I know variables-env don't behave the same... (maybe cross-env helped in normalize this)

vis-prime commented 1 year ago

yup windows 10 x64

abernier commented 1 year ago

In a *nix environment, you can pass "shell-variables" before any command, like FOO=bar here:

$ FOO=bar node -e "console.log(process.env.FOO)"

but this does not work exactly the same on windows... This is why you were having an error

You should probably use WSL for windows to avoiding such differences: https://learn.microsoft.com/en-us/windows/wsl/install

vis-prime commented 1 year ago

In a *nix environment, you can pass "shell-variables" before any command, like FOO=bar here:

$ FOO=bar node -e "console.log(process.env.FOO)"

but this does not work exactly the same on windows... This is why you were having an error

You should probably use WSL for windows to avoiding such differences: https://learn.microsoft.com/en-us/windows/wsl/install

need to get into bios to turn on 'virtualisation' for wsl to work

but unfortunately laptop's main screen is broken

forums suggested unplugging the display ribbon so that bios shows up on the external monitor , tried that too...but no luck

can't get into bios and cannot afford to fix this right now InShot_20230530_204510879

so putting this commit on hold for now 😢

abernier commented 1 year ago

omg 😱 this issue definitely went too far...

abernier commented 1 year ago

otherwise if cross-env does the trick it could also be a solution

vis-prime commented 1 year ago

otherwise if cross-env does the trick it could also be a solution

ohhh,...yess

the ci/codesandbox build ran correctly and i'm only using 'cross-env' for "run storybook" script,

the build and build-storybook are still the same

interesting... sb7 is back on the menu then... 🤯🤓

vis-prime commented 1 year ago

re - doing this