fix: resolve the console warning of shader material

pmndrs / drei-vanilla

🍦 drei-inspired helpers for threejs

https://pmndrs.github.io/drei-vanilla/

MIT License

448 stars 17 forks source link

Closed alexzhang1030 closed 12 months ago

alexzhang1030 commented 1 year ago

The console will print warning messages if using shaderMaterial

Cause we use assign to merge parameters and Three.ShaderMaterial. There is no need to use super(...parameters)

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d144984b708f4b22fdc077e425b2194bd4b7ca23:

Sandbox	Source
jolly-wave-23lpjt	Configuration
Ground reflections and video textures	Configuration
arc-x-pmndrs-colors	Configuration

vis-prime commented 1 year ago

typescript has no problems with this right ?

alexzhang1030 commented 12 months ago

typescript has no problems with this right ?

Yeah, tsc works well

vis-prime commented 12 months ago

alexzhang1030 commented 12 months ago

i changed one loadash.assign to Object.assign should be fine right ? 6cda825

I have merged the main branch, and no issues arose.

github-actions[bot] commented 12 months ago

:tada: This PR is included in version 1.11.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: