search

pmndrs / drei-vanilla

🍦 drei-inspired helpers for threejs
https://pmndrs.github.io/drei-vanilla/
MIT License
448 stars 17 forks source link

feat: introducing `Outlines` #35

Closed alexzhang1030 closed 1 year ago

alexzhang1030 commented 1 year ago

Why

Port the Outlines of drei.

What

Checklist

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 97b40f7584c18e2891e0d18dfba2762f7abda037:

Sandbox Source
clever-hoover-n9vnwy Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration
github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vis-prime commented 1 year ago

instead of "lodash-es" assign directly using "Object.assign" should work the same right ?

seems to be compatible https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#browser_compatibility

https://github.com/pmndrs/drei-vanilla/commit/6cda8252fc6d374802913a80c816566c97bf9143 let me know if this breaks the something, if it does then we can add lodash to package.json dependencies also

also instead of 'outline.render()' it could be 'outline.generate()' ?