search

pmndrs / ecctrl

🕹️ A floating rigibody character controller
MIT License
467 stars 50 forks source link

refactor: transform to monorepo #3

Closed ledouxm closed 9 months ago

ledouxm commented 9 months ago

Hello, following up my previous PR #2, this is a proposal for transforming the repo with duplicated files into a pnpm monorepo with 2 packages, lib and example.

For this to work, i had to set many deps to external in vite.config.ts, so the app using this lib needs :

Tho I believe it was never meant to be used without any of these.

You can try it using : pnpm --filter ecctrl build pnpm --filter example dev

I suspect you manually publish your releases so npm publish now becomes pnpm --filter ecctrl publish

ErdongChen-Andrew commented 9 months ago

Hi @ledouxm, thanks for your proposal! To be honest, I'm not really familiar with using pnpm. I have tested it locally, but it's not working as I expected. I think I will stick with the TypeScript version you provided and continue development based on that. Thanks for your effort! 😊