pmndrs / ecctrl

🕹️ A floating rigibody character controller
MIT License
530 stars 63 forks source link

Optional jumpIdle is not optional #55

Closed campbellgoe closed 5 months ago

campbellgoe commented 5 months ago

on line 29 of EcctrlAnimation.tsx is this code which I think is trying to set actions[props.animationsSet.jumpIdle] but jumpIdle is optional, so the code fails if you've removed it

29: const action =
      actions[curAnimation ? curAnimation : props.animationSet.jumpIdle];

For now the solution for the user is to always specify jumpIdle in the animation set.

ErdongChen-Andrew commented 5 months ago

Yea, all these animations are essential.

截屏2024-04-28 16 45 40
campbellgoe commented 5 months ago

thanks. since i needed to remove jump I just set it to a wave animation.