pmndrs / eslint-plugin-valtio

An eslint plugin for better valtio experience
MIT License
78 stars 6 forks source link

update dev dependencies, husky, prettier, eslint configs #21

Closed dai-shi closed 2 years ago

dai-shi commented 2 years ago

to be sync as much as possible with the valtio repo.

github-actions[bot] commented 2 years ago

Size Change: +58 B (+2%)

Total Size: 3.13 kB

Filename Size Change
dist/index.js 3.13 kB +58 B (+2%)

compressed-size-action

barelyhuman commented 2 years ago

Mostly done, One thing pending is moving from babel-eslint to @babel/eslint-parser, the newer @babel/eslint-parser might not be in sync with the existing checks for mutating the proxy state, which I'll be checking later tomorrow,

please avoid making a release till then, there's typo in the PR #20 , for one of the lines, while the test cases worked, there's still an issue, which is fixed in this

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60af1a491b1ccf2397dcc1c85b3d99e4cae08eb5:

Sandbox Source
Vanilla Configuration
React Configuration
barelyhuman commented 2 years ago

@dai-shi mostly done, would want you to test the CSB package once before we merge, I'm also doing it

dai-shi commented 2 years ago

Would it be possible to make the package json file as close as possible to the one in the valtio repo? Especially the order of fields (because we use diff to see differences). Not crucial but seems consistent and easy to follow.

barelyhuman commented 2 years ago

Will be done 👍🏼