search

pmndrs / examples

🍱 A monorepo holding pmndrs demos
https://pmndrs.github.io/examples/
MIT License
19 stars 6 forks source link

problematic demos #38

Open abernier opened 3 months ago

abernier commented 3 months ago

Excluding "minor" coloring/lightning/tonmapping issues https://github.com/pmndrs/examples/issues/11

Here are the "problematic" demos that:

does not build

Some demos/* have been temporarily disabled (renamed "bbuild2" with 2 "b" instead of "build2" like others one) because of build errors.

For them, please test with:

$ npm run -w demos/bvh bbuild2
$ # if succeeded, renane `demos/bvh/package.json#scripts.bbuild2` into `build2`

is blank or error(s) in console

$ npm run -w demos/basic-ballpit dev

something is broken compared to original

rndexe commented 3 months ago
rndexe commented 3 months ago
abernier commented 3 months ago

cannot check yourself the ticks in the desc I've written?

rndexe commented 3 months ago

No, they are disabled

rndexe commented 3 months ago

Simple physics demo with debug bounds has also been fixed

rndexe commented 3 months ago

These demos are also now fixed:

https://pmndrs.github.io/examples/demos/bvh https://pmndrs.github.io/examples/demos/grass-shader https://pmndrs.github.io/examples/demos/infinite-scroll https://pmndrs.github.io/examples/demos/horizontal-tiles https://pmndrs.github.io/examples/demos/monitors

rndexe commented 3 months ago

These are the problematic demos I have not been able to fix. Categorising them roughly according to issues I have noticed. They may have multiple other problems as well.

External Library issues : https://pmndrs.github.io/examples/demos/interactive-spline-scene-live-html https://pmndrs.github.io/examples/demos/spline-glass-shapes

Typescript build issues : https://pmndrs.github.io/examples/demos/racing-game

Postprocessing/Effects issues : https://pmndrs.github.io/examples/demos/space-game https://pmndrs.github.io/examples/demos/mount-transitions https://pmndrs.github.io/examples/demos/sparks-and-effects https://pmndrs.github.io/examples/demos/flexbox-yoga-in-webgl https://pmndrs.github.io/examples/demos/html-input-fields https://pmndrs.github.io/examples/demos/router-transitions https://pmndrs.github.io/examples/demos/stage-presets-gltfjsx

Vite Module externalized for browser compatibility issues : https://pmndrs.github.io/examples/demos/gpgpu-curl-noise-dof https://pmndrs.github.io/examples/demos/threejs-journey-portal https://pmndrs.github.io/examples/demos/shader-fire

abernier commented 3 months ago

maybe time for us to remove the ones we cannot migrate, for ex: racing-game is way too big to be included (and maintained...) <= may be a good candidate to remove from examples

rndexe commented 3 months ago

I've been trying to update these three examples to use vite-plugin-glslify instead of babel plugins https://pmndrs.github.io/examples/demos/gpgpu-curl-noise-dof https://pmndrs.github.io/examples/demos/threejs-journey-portal https://pmndrs.github.io/examples/demos/shader-fire

They build fine in dev and build when running with 

npm run -w demos/threejs-journey-portal/ build
npm run -w demos/threejs-journey-portal/ preview

But it doesn't work when building with npm run build && npx serve out

I tried adding the plugin to vite.config.build.ts in packages/e2e/src, but that doesn't work either.

abernier commented 3 months ago

thank you, will check this soon ;)