pmndrs / examples

🍱 A monorepo holding pmndrs demos
https://pmndrs.github.io/examples/
MIT License
19 stars 6 forks source link

fix: add bounding sphere to grass shader demo #82

Closed isaac-mason closed 2 months ago

isaac-mason commented 3 months ago
abernier commented 3 months ago

hey @isaac-mason thx, is it ready for merge?

hichemfantar commented 3 months ago

Thanks for the pr! I'll test and report back asap

hichemfantar commented 3 months ago

The bug seems to be fixed! I have a question, is there any performance impact with adding a bounding sphere? Also the entire grass shader example seems to have performance pitfalls according to this thread. Do you agree that we should update the implementation?