search

pmndrs / gltfjsx

🎮 Turns GLTFs into JSX components
https://gltf.pmnd.rs
MIT License
4.45k stars 290 forks source link

Shadow setting is not respected when in instance mode #123

Open vincent-lecrubier-skydio opened 2 years ago

vincent-lecrubier-skydio commented 2 years ago

The shadow setting is not respected when in instance mode.

npx gltfjsx public/drone.gltf --types --shadows --instanceall does not cast shadows

npx gltfjsx public/drone.gltf --types --shadows does cast shadows

drcmda commented 2 years ago

castShadow and receiveShadow go directly on the <Merged> component, you can't have have individual things have shadows or not. it should probably still add it, would you want to make a pr?

Daavidaviid commented 2 years ago

castShadow and receiveShadow go directly on the <Merged> component, you can't have have individual things have shadows or not. it should probably still add it, would you want to make a pr?

How would one do to have some elements without shadow ? Add them to the scene outside of the <Merged> ? Or in another <Merged> without shadows ?

SuddenDevelopment commented 1 year ago

adding to the merged tag is what is expected behavior