When .glb file does not exist (or path is wrong), command still adds .jsx file to repo

pmndrs / gltfjsx

🎮 Turns GLTFs into JSX components

https://gltf.pmnd.rs

MIT License

4.42k stars 290 forks source link

When .glb file does not exist (or path is wrong), command still adds .jsx file to repo #184

Open dataseyo opened 1 year ago

dataseyo commented 1 year ago

If you try to run the command on a file that doesn't exist, or if you get the path wrong, you get an empty .jsx file in your repository. This seems like undesirable behavior and I'm sure I could implement a quick fix. Is it okay if I submit a PR?

drcmda commented 1 year ago

sure!

dataseyo commented 1 year ago

Forked the repo and submitted a pr #185

dataseyo commented 1 year ago

@drcmda just wanted to send a gentle nudge that I resolved the empty file issue