test: incorporate eslint-plugin-testing-library and fix reported issues

pmndrs / jotai

👻 Primitive and flexible state management for React

https://jotai.org

MIT License

18.72k stars 617 forks source link

test: incorporate eslint-plugin-testing-library and fix reported issues #2799

Closed kretajak closed 1 week ago

kretajak commented 1 week ago

Summary

Testing Library provides Eslint plugin which encourages to use best practices.

Check List

[ x] pnpm run prettier for formatting code and docs

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 6, 2024 10:19pm

codesandbox-ci[bot] commented 1 week ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions[bot] commented 1 week ago

Preview in LiveCodes

Latest commit: 6a13b858baa0c7d3783ae9f86a92cc09cfedf74c
Last updated: Nov 6, 2024 10:18pm (UTC)

Playground	Link
React demo	https://livecodes.io?x=id/5YW9R873Q

See documentations for usage instructions.

dai-shi commented 1 week ago

Thanks for working on it. Definitely seems like an improvement. As always, we need to keep things sync between zustand, jotai and valtio. Please file PRs to two other repos.

kretajak commented 1 week ago

Thanks for working on it. Definitely seems like an improvement. As always, we need to keep things sync between zustand, jotai and valtio. Please file PRs to two other repos.

I have added similar PRs to zustand and valtio.

dai-shi commented 1 week ago

Thanks!!!

https://github.com/pmndrs/zustand/pull/2844 https://github.com/pmndrs/valtio/pull/992