search

pmndrs / lamina

🍰 An extensible, layer based shader material for ThreeJS
MIT License
1.01k stars 41 forks source link

Add all base material properties to debugger #23

Open supermoos opened 2 years ago

supermoos commented 2 years ago

Seems like now it just exposes base color, alpha and lighting. Since lighting changes the base material perhaps the base materials properties (roughness, transmission etc.) could then be exposed too?

FarazzShaikh commented 2 years ago

Base material properties can be passed into the component/constructor just like you do for regular materials.

<LayerMaterial roughness={…} transmission={…} />

supermoos commented 2 years ago

I know, that's not what the issue / feature request was about :-) I'll try and explain it better. If you look at the screenshot below, it's using DebugLayerMaterial, it would be great if the default props of the base material where visible and adjustable in this dialog too, instead of just base and alpha.

Screenshot 2022-04-04 at 14 15 00
FarazzShaikh commented 2 years ago

Ahh I see, that would be great but it would clutter up the debug panel with a long list of sliders.

It’s also difficult to extract properties that make sense to be sliders dynamically. I’ll give it a go for the next release but no promises haha

supermoos commented 2 years ago

Could be collapsed In a group by default :)