pmndrs / react-spring

✌️ A spring physics based React animation library
http://www.react-spring.dev/
MIT License
28.05k stars 1.19k forks source link

fix(#2173): add explicit dep for @react-spring/rafz for yarn and pnpm #2270

Closed wegry closed 4 months ago

wegry commented 5 months ago

Why

2173 points out that TypeScript types for @react-spring/web depend on @react-spring/rafz. In Yarn 4 with PnP enabled (and maybe pnpm with no-hoist enabled), this requires the user to explicitly import or override dependencies for @react-spring/web.

What

This PR adds the TypeScript dependency explicitly.

Checklist

Closes #2173

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 3f557f6d080c4089ac95e8a562a35a72bca0af01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-spring ❌ Failed (Inspect) Apr 10, 2024 5:18pm
joshuaellis commented 5 months ago

Thanks for the contribution! You need to run yarn to update the lockfile :)

wegry commented 5 months ago

You need to run yarn to update the lockfile :)

@joshuaellis done.

joshuaellis commented 5 months ago

⚠️ No Changeset found

Latest commit: 3f557f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

did you see this message? :)

wegry commented 5 months ago

@joshuaellis I had not. See 3e3dbac. Not sure why style checks are failing now for files I didn't change though.