pmndrs / react-three-a11y

♿️ Accessibility tools for React Three Fiber
https://docs.pmnd.rs/a11y/introduction
Other
561 stars 16 forks source link

Role image and custom tag for role content #26

Closed AlaricBaraou closed 3 years ago

AlaricBaraou commented 3 years ago

Add a new role image.

Give the possibility to pass the props tag to A11y components with role content in order to be able to use a custom tag when more appropriate and semantically correct.

So far limited to 'p' | 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6';

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0f4758d8b5b63fd95e150bc2b42fcec58bdacec7:

Sandbox Source
MR_main_a11y_features_test Configuration
github-actions[bot] commented 3 years ago

size-limit report 📦

Path Size
dist/a11y.cjs.production.min.js 4.43 KB (+4.81% 🔺)
dist/a11y.esm.js 4.47 KB (+4.89% 🔺)
AlaricBaraou commented 3 years ago

https://codesandbox.io/s/patient-sunset-vxld1?file=/src/App.js

For some reasons it's not working on this one. The section doesn't have style applied like it should. I'll check later.