search

pmndrs / react-three-editor

🔌 A one of a kind scene editor that writes changes back into your code
MIT License
621 stars 40 forks source link

`_source` added to Fragment #38

Open hasparus opened 1 year ago

hasparus commented 1 year ago

Sup folks. Firstly, I love this package. Thank you so much for your work on it.

I've encountered the following error from React.

`_source` supplied to `React.Fragment`. React.Fragment can only have `key` and `children` props.

_source is added to props of every element, including fragments. After a quick skim of the code, I think it happens here: https://github.com/pmndrs/react-three-editor/blob/main/packages/vite/src/babel/babel.ts#L240-L253

I suppose I should ask — can anything break if I added an if statement there to avoid adding _source to Fragments? Is there any other piece of the code that expects _source to be given to all elements?

nksaraf commented 1 year ago

No that would be perfect!