search

pmndrs / react-three-fiber

🇨🇭 A React renderer for Three.js
https://docs.pmnd.rs/react-three-fiber
MIT License
27.24k stars 1.56k forks source link

RFC: v9 goals #2338

Open krispya opened 2 years ago

krispya commented 2 years ago

Let's discuss some v9 goals here. These are all tentative right now.

Completed

TODO

Pending

krispya commented 2 years ago

I'd also like to discuss making renderer.physicallyCorrectLights = true by default. See: https://github.com/pmndrs/react-three-fiber/issues/2127

CodyJasonBennett commented 2 years ago

I don't think we can change defaults for lighting OOTB, problems are detailed in the linked issue. That might be a consideration for #2299 but the issue of decay not respecting physicallyCorrectLights remains. I think this is something to be considered in threejs itself.

krispya commented 2 years ago

I don't think we can change defaults for lighting OOTB, problems are detailed in the linked issue. That might be a consideration for #2299 but the issue of decay not respecting physicallyCorrectLights remains. I think this is something to be considered in threejs itself.

Agreed.

After a conversation with Paul, I'm making sure a pass on the frameloop modes is also on the to-do list. In particular demand needs to be updated so that it skips the render loop but still tracks delta so starting and stopping render doesn't destroy delta based animations.

saitonakamura commented 2 years ago

What are your thoughts on updating to zustand v4?

krispya commented 1 year ago

I'm in favor, the typing is hugely improved and so is compatibility with context. But it isn't a trivial update. Is it something you would be interested in spearheading? I can contribute.

saitonakamura commented 1 year ago

Yeah, I think so. When upgrading to r3f v8 I erroneously update zustand to v4. I had to revert back of course but not until I had some fair share of migration experience (we use it too)

krispya commented 1 year ago

That would be great. If you start a branch, I can do review and assist.

CodyJasonBennett commented 1 year ago

Just did this with react-ogl in https://github.com/pmndrs/react-ogl/pull/75, giving it a try here in https://github.com/pmndrs/react-three-fiber/pull/2558.

krispya commented 1 year ago

Thanks so much for all your hard work Cody. I wanted to add here some type exports for the different r3f props which were previously exported as Vector3, Color, etc.

aspheris commented 1 year ago

Hello! Whats the status of V9? I'm looking to use the lifecycle stages in useUpdate but it looks like its not officially ready yet.

krispya commented 1 year ago

Hello! Whats the status of V9? I'm looking to use the lifecycle stages in useUpdate but it looks like its not officially ready yet.

Hey! So we have been working on projects in parallel to this one and trying out some of the v9 updates internally as we go along. For example, I am exploring alternatives to useUpdate that are more robust for video game style apps right now. It may be a little bit longer before there is a stable version available.