search

pmndrs / react-three-fiber

🇨🇭 A React renderer for Three.js
https://docs.pmnd.rs/react-three-fiber
MIT License
27.64k stars 1.6k forks source link

Updating from 8.15.19 to 8.16.1 causes 'demand' frameloop issues with @react-spring/three #3228

Open GibsDev opened 7 months ago

GibsDev commented 7 months ago

This seems to be related to the problem in this react-spring issue, but I've narrowed the conditions down to changing the version of @react-three/fiber.

For some reason when updating to 8.16.1, the react spring animations are stopping short of completion.

I am using a spring with an onUpdate function tha calls invalidate() so the screen will dynamically update when the animation spring changes.

Something about the upgrade from 8.15.19 to 8.16.1 has changed the invalidation behavior, and the animation stops short of completion.

I've outlined some details in the other issue here.

CodyJasonBennett commented 7 months ago

This is probably caused by exactly https://github.com/pmndrs/react-three-fiber/releases/tag/v8.16.1. Maybe try 8.16.0.

GibsDev commented 6 months ago

This does not work with 8.16.0

CodyJasonBennett commented 3 months ago

Do you still have the project around or a lockfile you can provide? I'm expecting the versions to be misleading if you specified them with ^x.x.x which upgrades to the latest version always. If you remove ^, your package manager will install the exact version you specified.