fix: createPortal effect merging stale data from initial render

pmndrs / react-three-fiber

🇨🇭 A React renderer for Three.js

https://docs.pmnd.rs/react-three-fiber

MIT License

27.64k stars 1.6k forks source link

Closed notrabs closed 6 months ago

notrabs commented 6 months ago

Fixes #3253

Added a missing dependency on the inject function, which caused the effect to update a portal's store with stale data from the initial render
The store destruction has been moved to a separate hook, so it continues to run only on component unmount

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b4e0e3a88e3dcd5e6384c41b71f35fbfc8d24a17:

Sandbox	Source
example	Configuration

notrabs commented 6 months ago

Testing locally, I now get the expected sequence of events (using the minimal repro):