search

pmndrs / react-three-fiber

🇨🇭 A React renderer for Three.js
https://docs.pmnd.rs/react-three-fiber
MIT License
27.62k stars 1.6k forks source link

onPointerMissed is never called in react-native #3316

Open krzys-h opened 3 months ago

krzys-h commented 3 months ago

Similar story to #3315 - the code attempts to access e.offsetX here: https://github.com/pmndrs/react-three-fiber/blob/v8.16.8/packages/fiber/src/core/events.ts#L175-L176 which does not exist on react-native events.

This in turn causes the calculateDistance calculation to always return NaN and if (delta <= 2) to never match.

Neosoulink commented 2 months ago

Is there any update about this? I can fix it

cc: @CodyJasonBennett

CodyJasonBennett commented 2 months ago

No, generally updates occur naturally in their pertinent issues; you don't have to ping me for an update.

I'm not sure this is exactly true of a diagnosis, or perhaps we're not mutating the right reference here.

https://github.com/pmndrs/react-three-fiber/blob/3200547951f0f4c0b6859f5848012cf9d003cb70/packages/fiber/src/native/Canvas.tsx#L143-L156