Closed saitonakamura closed 3 years ago
would like to merge but asking in case, did you test the PR locally?
Yes, I tested it on a case from codesandbox and on the bunch of stories in storybook (I use that PR I've opened). Now that you've mentioned it I also checked the example and it's not working, but it's also not working for me locally in master
Error is
Failed to compile.
./src/index.js
Error: Duplicate plugin/preset detected.
If you'd like to use two separate instances of a plugin,
they need separate names, e.g.
plugins: [
['some-plugin', {}],
['some-plugin', {}, 'some unique name'],
]
Duplicates detected are:
[
{
"alias": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js",
"dirname": "/Users/saitonakamura/code/react-three-flex-copy/examples",
"ownPass": false,
"file": {
"request": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js",
"resolved": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js"
}
},
{
"alias": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js",
"dirname": "/Users/saitonakamura/code/react-three-flex-copy/examples",
"ownPass": false,
"file": {
"request": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js",
"resolved": "/Users/saitonakamura/code/react-three-flex-copy/examples/node_modules/react-refresh/babel.js"
}
}
]
at cachedFunction.next (<anonymous>)
^C
when you run yarn start
in examples, so I'm pretty sure it's not my changes that broke it
my bad I've updated react-scripts so this is the cause
also i'll merge the storybook pr as well
done. both pr merged @saitonakamura :P
Yay thanks! This really helps (we're developing a ui for a vr so flex engine is pretty much a must have)
Fixes #56