search

pmndrs / react-three-flex

💪📦 Flexbox for react-three-fiber
MIT License
1.65k stars 42 forks source link

Added ref forwarding to Flex and Box #58

Closed saitonakamura closed 3 years ago

saitonakamura commented 3 years ago

This would with various helpers and hooks that use refs to somehow affect the component, say rotate it or draw a bounding box My use case is to draw a UI on a plane than rotate it towards the eyesight in vr

Any thoughts against it? One other thing is that because of the additional indent it looks like everthing has changed, but it's not. Maybe we want to extract a top level function we'll pass to React.forwardRef?

giulioz commented 3 years ago

Can you please rebase?

saitonakamura commented 3 years ago

@giulioz sure, done

saitonakamura commented 3 years ago

not sure what's with the ci, commands looks fine locally