search

pmndrs / react-three-flex

💪📦 Flexbox for react-three-fiber
MIT License
1.65k stars 42 forks source link

typescript errors with r3f v8 #78

Closed oveddan closed 2 years ago

oveddan commented 2 years ago

Related to issue #2190 in r3f

oveddan commented 2 years ago

When upgrading react three fiber to v8 and above, Box asks you to now define attachArray={undefined} attachObject={undefined} attachFns={undefined} or else you get a typescript error:

return (
        <Box attachArray={undefined} attachObject={undefined} attachFns={undefined}>
          {children}
        </Box>
      );
oveddan commented 2 years ago

I believe flex needs to upgrade to support the new attach api?

saitonakamura commented 2 years ago

Yeah. I think so. Would be a major release

giulioz commented 2 years ago

Potential fix on https://github.com/pmndrs/react-three-flex/pull/79

jemgold commented 2 years ago

did anyone figure this out? still seems to be a problem w/ flex1.0.0, fiber@8.0.27