search

pmndrs / react-three-offscreen

📺 Offscreen worker canvas for react-three-fiber
https://offscreen.pmnd.rs
MIT License
456 stars 19 forks source link

Support React.StrictMode #19

Closed eyr1n closed 4 months ago

eyr1n commented 5 months ago

This PR fixes the problem of transferControlToOffscreen being called twice under React.StrictMode.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-three-offscreen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 10:39pm
mofJon commented 5 months ago

Hi @eyr1n!

You wouldn't happen to ahve this working in NextJS 14, would you?

drcmda commented 4 months ago

@eyr1n do you use this package? would you be interested in having maintenance rights so that somebody can look over it from time to time? i've not even seen the notifications because github sends too many.

eyr1n commented 4 months ago

@eyr1n do you use this package? would you be interested in having maintenance rights so that somebody can look over it from time to time? i've not even seen the notifications because github sends too many.

@drcmda I use this package for the products at work and I'm interested in becoming the maintainer of this package. I would love to participate if possible!

eyr1n commented 4 months ago

You wouldn't happen to ahve this working in NextJS 14, would you?

@mofJon I checked it works with Next.js 14(reactStrictMode: true).

mofJon commented 4 months ago

Thanks guys!

You're both lifesavers! Were really depending on using this at work to get a project out the door.

Thanks,

Jon

On Wed, May 8, 2024 at 12:05 PM Rin Iwai @.***> wrote:

You wouldn't happen to ahve this working in NextJS 14, would you?

@mofJon https://github.com/mofJon I checked it works with Next.js 14(reactStrictMode: true).

— Reply to this email directly, view it on GitHub https://github.com/pmndrs/react-three-offscreen/pull/19#issuecomment-2100324738, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFB7EMZJJH33G73YOIHQYB3ZBIBHFAVCNFSM6AAAAABG7FC5USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQGMZDINZTHA . You are receiving this because you were mentioned.Message ID: @.***>

--

JON COUCH

Lead Creative Frontend Developer

Matter Of Form http://matterofform.com/ | We help timeless brands design what’s next.

T: 020 3141 2000

A: 168 Shoreditch High Street, E1 6HU

Brand & Digital Experience for Category Leaders, globally. Follow us on Instagram @matterofform https://www.instagram.com/matterofform/ for all things culture, subscribe http://eepurl.com/hhI7_P to our monthly circular on luxury trends, or kick back and watch our showreel https://vimeo.com/matterofform/showreel2022.