search

pmndrs / three-stdlib

📚 Stand-alone library of threejs examples designed to run without transpilation in node & browser
https://npmjs.com/three-stdlib
MIT License
676 stars 110 forks source link

fix(STLExporter): no positionAttributes + TS #326

Closed stockhuman closed 5 months ago

stockhuman commented 6 months ago

Hello!

This fixes the facet normal / vertex text interpolation bug from the previous TS conversion and guards against positionAttribute-less meshes.

Why

I happened to use the library before d5df2b33cec6b0410a6d1c2beed1787955f6816b, and independently fixed the Typescript implementation, where a simple text interpolation error prevented string export.

Not present in either ts/js impl. is a small change to improve robustness, where a malformed (or custom) elements might break the exporter when missing a position buffer attribute. This change was implemented here, and should be up for a while.

CodyJasonBennett commented 6 months ago

I'll need to look into the new syntax for bone transforms to clear CI (we support r128-current), but otherwise looks good.

CodyJasonBennett commented 5 months ago

https://github.com/mrdoob/three.js/pull/25586

codesandbox-ci[bot] commented 5 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 2.29.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: