search

pmndrs / three-stdlib

📚 Stand-alone library of threejs examples designed to run without transpilation in node & browser
https://npmjs.com/three-stdlib
MIT License
676 stars 110 forks source link

fix(types): remove references to Shader type #327

Closed Methuselah96 closed 6 months ago

Methuselah96 commented 6 months ago

Why

The types have errors when used with @types/three@0.160.0, because the Shader type was removed in @types/three@0.160.0 due it it being used in ways it wasn't intended to be used. The type errors are:

Error: ./node_modules/three-stdlib/postprocessing/ShaderPass.d.ts(1,10): error TS2305: Module '"three"' has no exported member 'Shader'.
Error: ./node_modules/three-stdlib/shaders/types.d.ts(1,25): error TS2305: Module '"three"' has no exported member 'Shader'.

What

Remove use of the Shader type with more suitable types.

Checklist

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

CodyJasonBennett commented 6 months ago

Thanks.

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 2.28.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: