Non-passive event listener to a scroll-blocking 'wheel' event - Githubissues

pmndrs / three-stdlib

📚 Stand-alone library of threejs examples designed to run without transpilation in node & browser

https://npmjs.com/three-stdlib

MIT License

704 stars 117 forks source link

Non-passive event listener to a scroll-blocking 'wheel' event #352

Closed satelllte closed 5 months ago

satelllte commented 6 months ago

[!NOTE] This is not a bug, but just a console warning and a small thing to improve. So please consider it.

Versions

three: 0.163.0
@types/three: 0.163.0
three-stdlib: 2.29.6
@react-three/drei: 9.103.0

Problem description:

Go to https://drei.pmnd.rs/iframe.html?id=controls-orbitcontrols--orbit-controls-story&viewMode=story
Open console
See warning:

[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

Suggested solution:

Put passive: true here: https://github.com/pmndrs/three-stdlib/blob/017639d81eb65b3a69b334ec1792efcf6f4a2215/src/controls/OrbitControls.ts#L412