pmndrs / three-stdlib

📚 Stand-alone library of threejs examples designed to run without transpilation in node & browser
https://npmjs.com/three-stdlib
MIT License
733 stars 119 forks source link

wrong type in defaultColor in OutlineEffect #379

Open igpdev-428 opened 2 months ago

igpdev-428 commented 2 months ago

Problem description:

defaultColor in OutlineEffectParameters for the OutlineEffect class is set to number[]. It should probably be Color

Relevant code:

export interface OutlineEffectParameters { defaultThickness?: number | undefined defaultColor?: number[] | undefined defaultAlpha?: number | undefined defaultKeepAlive?: boolean | undefined }

Suggested solution:

Change it to be Color type. Thank you for providing this library for us developers.