search

pmndrs / uikit

🎨 user interfaces for react-three-fiber
https://pmndrs.github.io/uikit/docs/
Other
2.61k stars 135 forks source link

[Vanilla] - `hover` and `active` props do not seem to work after `0.3.4` #72

Closed michealparks closed 4 months ago

michealparks commented 4 months ago

Hello, first I just want to say thank you for this incredible library!

I'm a Threlte maintainer and over the past few weeks I've been working on a Threlte library that wraps the vanilla UIKit export (@pmndrs/uikit). After upgrading from 0.3.4, hover and active props seem to no longer have any effect. I've created two small stackblitz repos to demonstrate:

mrxz commented 4 months ago

Ran into the same issue when updating from v0.3.4 to v0.3.6 in my project. Turns out that for vanilla projects the eventnames are now expected to be lowercase (https://github.com/pmndrs/uikit/commit/9d52cc8ec96fac2167d997373c740c196e38bbbd), so pointerover instead of pointerOver. I've created a PR (#73) to update the docs and example to reflect this, but obviously we'll have to change the eventnames on our ends as well.

bbohlender commented 4 months ago

@michealparks @mrxz Sorry, I actually wasn't aware of anybody already using those events. In the future, I'll make sure I create a release note at least; sorry for the inconvenience.

It was actually planned to do a threlte version of that, so I am very excited that somebody is already doing that.

I'd like to learn more about your use case and technology stack since I am also working on unpublished complementary libraries that might be interesting. Consider DMing me on twitter / discord in case any of you wants to chat!

bbohlender commented 4 months ago

Thanks to @mrxz, the docs and example are now updated (#73) Sorry again for the inconvenience. From now on I'll be more aware of the vanilla users ;-)