Convert worker into static import & update deps and demos

pmndrs / use-cannon

👋💣 physics based hooks for @react-three/fiber

https://cannon.pmnd.rs

2.78k stars 156 forks source link

Convert worker into static import & update deps and demos #145

Closed stockhuman closed 3 years ago

stockhuman commented 3 years ago

Hello folks. :)

This implements @darwin's fork (#132), which solves #143, and potentially more. It also deals with the cyclical dependency warning.

Additionally, the demos have been cleaned up (removed sRGB prop, corrected an import that assumed a dev environment, &c) and some dependencies updated.

stockhuman commented 3 years ago

My only question before merging this is about the decision to lazy load; if this was a performance concern that I'm not noticing or something else. Thanks :)

drcmda commented 3 years ago

sorry for late review, had so much on my plate, merge it! :-) @stockHuman

drcmda commented 3 years ago

also @darwin if you want to work officially on use-cannon, i think everyone would like that!

stockhuman commented 3 years ago

@drcmda No problem at all! I can see how alive the Discord is, and that's surely not the least of what's on your plate. Anyway, thanks :)