search

pmndrs / use-cannon

👋💣 physics based hooks for @react-three/fiber
https://cannon.pmnd.rs
2.78k stars 156 forks source link

fix pong demo #157

Closed dreammonkey closed 3 years ago

stockhuman commented 3 years ago

Hey Diederik, thanks for this, and for your previous pull I seem to have rolled over.

This seems to fix things, but would you know if this is original to the earlier demo? The ball seems to sink into the paddle. image

dreammonkey commented 3 years ago

Good catch ! 😎

I honestly hadn't noticed, if it wasn't in the original demo chances are small that my contribution causes this to happen (you'll see my point when you look at the changes I've made)

I was just happy the errors were gone, but there could be more going on with this demo than I expected. Probably better to leave it to the original author to fix.

dreammonkey commented 3 years ago

I just saw this: https://github.com/pmndrs/use-cannon/discussions/94#discussioncomment-33641

Should be fairly easy to fix

stockhuman commented 3 years ago

Thanks, Diederik. Look how far the lib has come - already suffering from code rot! :)

Fixed here