Move web worker and types into @pmndrs/cannon-worker-api package

pmndrs / use-cannon

👋💣 physics based hooks for @react-three/fiber

https://cannon.pmnd.rs

2.74k stars 153 forks source link

Move web worker and types into @pmndrs/cannon-worker-api package #358

Closed isaac-mason closed 2 years ago

isaac-mason commented 2 years ago

Move setup types and body props types into @pmndrs/cannon-worker-api package
Move cannon web worker into @pmndrs/cannon-worker-api package
Update @react-three/cannon to use @pmndrs/cannon-worker-api

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/use-cannon/7nLxAPVvpkmcZH1Eb5TX89Z8eefT
✅ Preview: https://use-cannon-git-fork-isaac-mason-feature-cannon-wo-aedab0-pmndrs.vercel.app

bjornstar commented 2 years ago

TODO

Change @pmndrs/cannon-worker-api body types to use shape instead of args

Have @react-three/cannon shapes use args for backwards compatibility

Avoiding using args in @pmndrs/cannon-worker-api as it is a r3f pattern

Only re-export types from @pmndrs/cannon-worker-api in @react-three/cannon

Let's start with getting @pmndrs/cannon-worker-api released before we start iterating on the API.

isaac-mason commented 2 years ago

Okay sounds good. I'll just move a couple more types around then will mark the PR as ready.

bjornstar commented 2 years ago

Cool, let me publish the package.