feat: uses preconstruct for the monorepo

gsimone commented 2 years ago

Changes

moves examples outside of packages
uses preconstruct to link and build packages
the cannon-worker package is still building using configured rollup since I couldn't find a way to fix the worker import.
- Looking for a solution here
Moved some deps around ( from deps to peer ), might need some double checking

Testing

Dev

Run:

yarn // installs all deps via workspaces & runs `preconstruct dev` to link local packages
yarn examples // launches the examples vite server

Navigate to the examples Make a change in anything in react-three-cannon and the vite server should refresh with the new changes

Build

Test a build, maybe publish as canary so we can try it around the world

TODO

[ ] Testing that it doesn't only work for me 🤡
[ ] Find a way to include cannon-worker in the workflow since it's convenient.
[ ] There's a multiple-three import warning when running the examples, what that already there?
[ ] Fix Vercel deploy

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/use-cannon/FfpyY6B48mNSXkU1bXGW6ncQthYH
✅ Preview: Failed

bjornstar commented 2 years ago

moves examples outside of packages

Is this necessary?

gsimone commented 2 years ago

moves examples outside of packages

Is this necessary?

It makes it easier to just jump to examples for new users and makes it clear that they are not anything that's built/exported/published

isaac-mason commented 2 years ago

This looks great! Preconstruct looks like it offers a way better dev experience.

We are planning on moving more logic into the @pmndrs/cannon-worker-api package over time. So without a solve for the worker package, this would become less useful as we move things 😢

As far as I can see, preconstruct doesn't support custom rollup plugins/addons - unless there's something I've missed?

Will do a bit more reading...

bjornstar commented 2 years ago

moves examples outside of packages

Is this necessary?

It makes it easier to just jump to examples for new users and makes it clear that they are not anything that's built/exported/published

Let's leave it how it was.

pmndrs / use-cannon