pmndrs / use-cannon

👋💣 physics based hooks for @react-three/fiber
https://cannon.pmnd.rs
2.73k stars 153 forks source link

Add scaleOverride to useBody props #374

Open krispya opened 2 years ago

krispya commented 2 years ago

Makes it so you can specifyscaleOverride in the uesBody props. Since most use cases I have for this initialize the scale on mount and then don't touch it, this method ends up being more compact and also lets me use the same scale factor in the body easily. For example:

const [ref, { at }] = useBox(() => {
    const scale = randomInRange(0.65, 1.2)
    return {
      args: [size * scale, size * scale, size * scale],
      mass: 1,
      position: [Math.random() - 0.5, Math.random() * 2, Math.random() - 0.5],
      scaleOverride: [scale, scale, scale],
    }
  })
vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
use-cannon ✅ Ready (Inspect) Visit Preview Apr 18, 2022 at 2:58AM (UTC)
krispya commented 2 years ago

I realized I was putting the type in the wrong place. I moved it to the hook and out of the worker.

bjornstar commented 2 years ago

Please resolve merge conflicts.

Also, this doesn't work because the scaleOverride is not being passed to useBody.