pmndrs / use-p2

👋💣 2d physics hooks for @react-three/fiber

https://p2.pmnd.rs

MIT License

147 stars 9 forks source link

Enable paused #5

Closed grndctrl closed 2 years ago

grndctrl commented 2 years ago

4

Better approach than my previous suggested PR. I basicly just copied @bjornstar's use-cannon PR and applied it to make it work for use-p2.

BREAKING: step renamed to stepSize (default: 1 / 60)
NEW: maxSubSteps (default: 10)
NEW: isPaused
timeSinceLastCall not tracked in worker
prefer FC to PropsWithChildren
REMOVED: type DefaultContactMaterial
MISSING: isPaused demo

grndctrl commented 2 years ago

Mind you, the same changes are all in the same PR over at use-cannon too though.

EDIT: Ah my bad, I think I misunderstood and you might be referring to all the changes that happened while I ran: npm run prettier-fix.

joergjaeckel commented 2 years ago

Yes that should be the reason. Thats not a problem at all but I cant review and understand the changes while I need to search them between all the reformattings 😅 Is it possible to correct this?

For context: I copied over the prettier config from the cannon repo but never executed it

joergjaeckel commented 2 years ago

I pushed a prettier-fixed commit, now if you merge the conflicts what remains should be your relevant changes.

grndctrl commented 2 years ago

Ok I merged your changes, also removed a big comment block I forgot to delete while testing.