pmndrs / valtio

🧙 Valtio makes proxy-state simple for React and Vanilla
https://valtio.dev
MIT License
8.84k stars 248 forks source link

refactor(vanilla): simplify handling object descriptor #654

Closed dai-shi closed 1 year ago

dai-shi commented 1 year ago

Thought this would be more consistent with https://github.com/pmndrs/valtio/pull/653#issuecomment-1416911665.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
valtio ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 1:57AM (UTC)
codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 399f92d7714418f3e8291c55c58c9dd0e1d7da50:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
github-actions[bot] commented 1 year ago

Size Change: -71 B (0%)

Total Size: 55.3 kB

Filename Size Change
dist/esm/vanilla.js 2.28 kB -8 B (0%)
dist/system/vanilla.development.js 2.42 kB -3 B (0%)
dist/system/vanilla.production.js 1.45 kB -10 B (-1%)
dist/umd/vanilla.development.js 2.58 kB -20 B (-1%)
dist/umd/vanilla.production.js 1.52 kB -11 B (-1%)
dist/vanilla.js 2.47 kB -19 B (-1%)
ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `dist/esm/index.js` | 62 B | | `dist/esm/macro.js` | 698 B | | `dist/esm/macro/vite.js` | 864 B | | `dist/esm/react.js` | 710 B | | `dist/esm/react/utils.js` | 221 B | | `dist/esm/utils.js` | 68 B | | `dist/esm/vanilla/utils.js` | 4.21 kB | | `dist/index.js` | 232 B | | `dist/macro.js` | 937 B | | `dist/macro/vite.js` | 1.09 kB | | `dist/react.js` | 652 B | | `dist/react/utils.js` | 237 B | | `dist/system/index.development.js` | 236 B | | `dist/system/index.production.js` | 170 B | | `dist/system/macro.development.js` | 779 B | | `dist/system/macro.production.js` | 556 B | | `dist/system/macro/vite.development.js` | 951 B | | `dist/system/macro/vite.production.js` | 660 B | | `dist/system/react.development.js` | 851 B | | `dist/system/react.production.js` | 466 B | | `dist/system/react/utils.development.js` | 316 B | | `dist/system/react/utils.production.js` | 221 B | | `dist/system/utils.development.js` | 241 B | | `dist/system/utils.production.js` | 176 B | | `dist/system/vanilla/utils.development.js` | 4.43 kB | | `dist/system/vanilla/utils.production.js` | 2.84 kB | | `dist/umd/index.development.js` | 372 B | | `dist/umd/index.production.js` | 322 B | | `dist/umd/macro.development.js` | 1.05 kB | | `dist/umd/macro.production.js` | 724 B | | `dist/umd/macro/vite.development.js` | 1.23 kB | | `dist/umd/macro/vite.production.js` | 882 B | | `dist/umd/react.development.js` | 797 B | | `dist/umd/react.production.js` | 519 B | | `dist/umd/react/utils.development.js` | 396 B | | `dist/umd/react/utils.production.js` | 297 B | | `dist/umd/utils.development.js` | 386 B | | `dist/umd/utils.production.js` | 333 B | | `dist/umd/vanilla/utils.development.js` | 4.7 kB | | `dist/umd/vanilla/utils.production.js` | 2.92 kB | | `dist/utils.js` | 236 B | | `dist/vanilla/utils.js` | 4.54 kB |

compressed-size-action

dai-shi commented 1 year ago

@stephenh Would you review this please?

dai-shi commented 1 year ago

Small disclaimer I am still in the "barely following along" stage of understanding and not "ah I immediately see why this is better" stage. :-)

Sure, totally fine. (And, there are only few who barely follow along.)